search

bymayanksingh / connect4

🎮 It is a two-player connection game in which the players first choose a color and then take turns dropping one colored disc from the top into a seven-column, six-row vertically suspended grid. The pieces fall straight down, occupying the lowest available space within the column, user wins by forming row of four of same color
MIT License
23 stars 27 forks source link

Bug in game:undo #13

Closed Satvinder31415 closed 4 years ago

Satvinder31415 commented 4 years ago

There is some issue in the code of game:undo. Test case: Upon starting the game,play 3 moves and then press Ctrl+Z twice. Firstly only one disc is removed when it should have been 2 and secondly the turn is of the wrong person. This issue can be further exploited in lots of ways to make theoretically impossible game configurations. connect4-e1

bymayanksingh commented 4 years ago

Yes, well I completely missed that, thanks for raising an issue.

would you like to fix this?

Satvinder31415 commented 4 years ago

Sure

ajaykumarr123 commented 4 years ago

I would like to work on this issue

bymayanksingh commented 4 years ago

@ajaykumarr123 @Satvinder31415 I hope you guys will work on this together.

ajaykumarr123 commented 4 years ago

ya sure

Satvinder31415 commented 4 years ago

I've rectified and sent a pull request regarding the same. You may review my code and suggest suitable changes.

bymayanksingh commented 4 years ago

@ajaykumarr123 the issue is actually resolved now, maybe you can raise and start working on a new suitable issue of your choice or choose an existing issue to work on.

ajaykumarr123 commented 4 years ago

I think I can help you in solving issue #7 and after that wants to join #3 so, can you assign me #7?