search

byme8 / ZeroQL

C# GraphQL client with Linq-like syntax
MIT License
278 stars 13 forks source link

Use netstandard 2.1 #47

Closed JuanuMusic closed 1 year ago

JuanuMusic commented 1 year ago

This completes the work for Issue #46

If this is not enough to merge, I'm hoping it's a goo place to start. I switched librearies to be netstandard2.1 Added required compatibility issues Added Portable.System.DateOnly to allow for DateOnly or TimeOnly classes on netstandard 2.1

byme8 commented 1 year ago

Have you tried to use this build inside Unity?

I am asking because, as far as I know, it is not enough just to define CallerArgumentExpressionAttribute or IsExternalInit to make it work. Yes, you fixed compilation errors. However, at runtime, it may fail because this feature is not supported by runtime itself.

I have tested it for net462, net72, and net48. Looks like it works fine. I will have a deeper look a bit later.

JuanuMusic commented 1 year ago

Hey, it's a good point. However, I am planning on using compiling my library with .net standard so that its usable from Unity. I wasn't really planning on using ZeroQL directly from Unity scripts.

I am assuming this is not a problem given that the queries will be already compiled on my library. I might be wrong.

Having said that my next step is to set up a unity project that uses my library, powered by ZeroQL.

byme8 commented 1 year ago

I created another pull request for netstandard support based on your changes.

This one has issues with the Nuget setup, doesn't have generation for ModuleInitilizer and doesn't have tests to make sure that it works on netstandard.

You can have a look at it here. Once I do all testing for .net framework, xamarin, unity and figure out how to add tests to it, I am going to merge my version and close this one.

JuanuMusic commented 1 year ago

Closed. better PR on #49 49