Update for GHC 8.4

[mr]

I've updated for 8.4, but it won't work for 8.4 unless these HaXml changes are implemented: https://github.com/mr/HaXml

However I wanted to keep this open at least as a reminder.

[byorgey]

Thanks so much!

[mr]

One issue is that it looks like it breaks on old versions. I might try adding CPP stuff or look into how other libraries do it.

[byorgey]

How old do you mean when you say "old versions"?

[mr]

I think it might be pre-8.0, you can check the Travis builds that failed.

On Wed, Jul 4, 2018, 3:38 PM Brent Yorgey notifications@github.com wrote:

How old do you mean when you say "old versions"?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/byorgey/haxr/pull/22#issuecomment-402548423, or mute the thread https://github.com/notifications/unsubscribe-auth/ACqSgM7DLiNSEl9JX6hWzeIS5TyN-C_bks5uDRmYgaJpZM4U-FX9 .

[mr]

https://travis-ci.org/byorgey/haxr/builds/398657030?utm_source=github_status&utm_medium=notification

[byorgey]

OK, at this point I'm not too worried about supporting pre-8.0, so let's not bother with CPP etc. Two versions back (= three versions total) is good enough.

[byorgey]

Thanks for your help! Have you been in touch with Malcolm Wallace (HaXml maintainer) at all? I know he sent a message to some mailing list a while back saying he intended to get around to this but I haven't heard anything since then.

[mr]

I sent him an email about the same time that I opened this issue, but I haven't heard back. Don't really know how to communicate with him outside using his email on the HaXml site.

On Wed, Jul 4, 2018, 3:54 PM Brent Yorgey notifications@github.com wrote:

Thanks for your help! Have you been in touch with Malcolm Wallace (HaXml maintainer) at all? I know he sent a message to some mailing list a while back saying he intended to get around to this but I haven't heard anything since then.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/byorgey/haxr/pull/22#issuecomment-402550519, or mute the thread https://github.com/notifications/unsubscribe-auth/ACqSgGiZ0i7YG8sLvkGUBXKU-yK0ehrwks5uDR2PgaJpZM4U-FX9 .

[byorgey]

I received an email he sent from the address malcolm.wallace@me.com on May 15.

[mr]

That's the one I used. I guess he's just busy. He may also be interested in keeping pre-8.0 versions around.

[sboosali]

I just them an email too.

I don't see an issue tracker or a repository for http://hackage.haskell.org/package/HaXml

[jwaldmann]

Thanks for keeping haxr alive. We are using it in some legacy code.

[sboosali]

@jwaldmann fyi you can patch haxr to import from https://github.com/sboosali/HaXML2 to build with ghc-8.4 (ghc-8.6 should work too, I'll double check this weekend).

btw, I changed the package name to HaXml2, for clarity, so you'll need to update the build-depends too.

[mr]

@sboosali is this in hackage?

[sboosali]

no, I was waiting to hear back from the author of HaXml (I sent an email like a month ago).

it's ready to be pushed to hackage (under a different name).

if the maintainers (pinging @byorgey) is interested in updating haxr off a fork, I'm more than happy to push it.

On Wed, Oct 10, 2018, 08:58 Megan Robinson notifications@github.com wrote:

@sboosali https://github.com/sboosali is this in hackage?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/byorgey/haxr/pull/22#issuecomment-428561259, or mute the thread https://github.com/notifications/unsubscribe-auth/ACNoMZx-mbPcCzj5RjAaT-5vWgklB4Uzks5uje73gaJpZM4U-FX9 .

[byorgey]

@sboosali I would be happy to switch haxr over to depending on a fork of HaXml which is actually maintained. However, note there is also a process for taking over as maintainer of a package, if the author doesn't respond. That might be better than making a fork since then other packages which depend on HaXml would work without having to update their dependencies.

[sboosali]

@byorgey that's great to hear.

Here are my thoughts.

I'm going to send them a patch and a changelog once I've finished testing them. Then I'm happy to wait for a bit (say, until ghc-8.6.2, when more people will upgrade, due to the ghc-8.6.1 optimizer bug). If we don't, if you're still willing to move haxr to the fork (haxml2) once I publish it to Hackage (for the near-term).

Some context(?): Malcolm Wallace seems to be the maintainer for both haxml and polyparse (a dependency). I spent the past few hours adding MonadFail instances / wrangling CPP. Tonight, I should finish the grunt work for updating HaXml for ghc-8.6 too (my fork I linked to, turns out, only works until ghc-8.4, due to the completion of the MonadFail proposal).

short-term, I don't intend to assume maintenance over either package, nor would I want to (since I'm unfamiliar with the code, and they seem to know what they're doing).

long-term, I would like to work with Malcolm on your features, if they're interested. For example, adding signatures to polyparse (because it defines a dozen different specialized parsers in separate modules, each along different string types (string versus strict text versus lazy text versus bytestring) and along tokenization (lexed versus raw). however, they seem to want portability with old GHC versions and with different Haskell compilers. Which is great! But those don't support backpack, and I don't even have any installed myself, so I don't know if that's compatible with their goals for those packages (another thing I'd like to ask them about).

Anyways, I would be open to contacting the trustees, but only if we haven't heard back for a while (like come ghc-8.8), and I doubt it'll come to that (since you said you heard back from them this year, no?).

On Wed, Oct 10, 2018, 22:47 Brent Yorgey notifications@github.com wrote:

@sboosali https://github.com/sboosali I would be happy to switch haxr over to depending on a fork of HaXml which is actually maintained. However, note there is also a process for taking over as maintainer of a package, if the author doesn't respond. That might be better than making a fork since then other packages which depend on HaXml would work without having to update their dependencies.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/byorgey/haxr/pull/22#issuecomment-428800624, or mute the thread https://github.com/notifications/unsubscribe-auth/ACNoMcQjY0zEsiA8i6SvnPck4Eqk_uEfks5ujrFbgaJpZM4U-FX9 .

[clinty]

https://github.com/haskell-infra/hackage-trustees/issues/186#issuecomment-434464232 may be relevant.

[sboosali]

@clinty thanks! i hadn't know about their work on it.

On Sun, Nov 4, 2018, 17:38 clinty <notifications@github.com wrote:

haskell-infra/hackage-trustees#186 (comment) https://github.com/haskell-infra/hackage-trustees/issues/186#issuecomment-434464232 may be relevant.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/byorgey/haxr/pull/22#issuecomment-435730424, or mute the thread https://github.com/notifications/unsubscribe-auth/ACNoMZYhSxbwJbChXKgStRVj4xTFTKXlks5ur5ahgaJpZM4U-FX9 .

[byorgey]

I have just uploaded haxr-3000.11.3 to Hackage which works under GHC 8.0-8.6. Please let me know if you run into any issues!