search

byorgey / haxr

Other
10 stars 16 forks source link

add `Semigroup` instance #24

Closed sboosali closed 5 years ago

sboosali commented 6 years ago

bump pvp minor version.

uses an updated HaXml: git@github.com:sboosali/HaXml2.git

(NOTE my updated HaXml also only added Semigroup instances, whose maintainer will eventually need to add anyways to work with the new base).

tested with GHC 8.4.3 on Linux.

byorgey commented 6 years ago

Thanks! But you seem to have also included a cabal.project file which contains a bunch of paths that are local to your filesystem?

byorgey commented 6 years ago

Also, there is already #22 - why open a new pull request? (I'm curious what is different.)

sboosali commented 6 years ago

Sorry, I didn't see an issue, so I didn't notice other pull requests.

The project file was an oversight (btw the paths are the nix package manager equivalent to /usr/).

On Tue, Sep 4, 2018, 9:41 PM Brent Yorgey notifications@github.com wrote:

Also, there is already #22 https://github.com/byorgey/haxr/pull/22 - why open a new pull request? (I'm curious what is different.)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/byorgey/haxr/pull/24#issuecomment-418571449, or mute the thread https://github.com/notifications/unsubscribe-auth/ACNoMaHWs4c7QdI027mT2NKabDauQ_6Lks5uXyuzgaJpZM4WWzSt .