search

byorgey / haxr

Other
10 stars 16 forks source link

add null support for <nil/> (haskell `()`) #27

Closed juhp closed 4 years ago

juhp commented 4 years ago

This seems to work for me, but a review would be most welcome. I am not sure if explicit () is needed "everywhere".

juhp commented 4 years ago

Oh I missed #20 ...

juhp commented 4 years ago

Using <nil/> you can now do something like

let url = "https://koji.fedoraproject.org/kojihub"
remote url "listTags" () (13722 ::Int) :: IO Value
byorgey commented 4 years ago

Very cool, thanks! I do have a suggestion about removing one explicit ().

juhp commented 4 years ago

Great, thanks a lot, I will try updating to incorporate your suggestions.

juhp commented 4 years ago

Seems to still work okay for me :+1:

juhp commented 4 years ago

Early wip koji library is now up on https://github.com/juhp/koji-hs

byorgey commented 4 years ago

Thanks!

byorgey commented 4 years ago

Uploaded to Hackage as haxr-3000.11.4.

juhp commented 4 years ago

Thanks!

I re-enabled haxr in Stackage Nightly too.

byorgey commented 4 years ago

Great, thanks!