search

byorgey / haxr

Other
10 stars 16 forks source link

haxr does not build with ghc-9.0 due to HaXml #30

Closed juhp closed 2 years ago

juhp commented 3 years ago

Unfortunately HaXml does not build yet with ghc-9.0: hackage-trustees/malcolm-wallace-universe#11. I actually only need it for haxr... I was told to make my own fork if I want to upload a fixed HaXml...

Just wondering what is the best approach here in terms of maintenance. Any thoughts or suggestions?

byorgey commented 3 years ago

Hmm, good question. Let's see if @phadej replies to that ticket, I'm not sure I understand the objection.

byorgey commented 3 years ago

Out of curiosity, what exactly did you have to change to get it to build with GHC-9.0? I don't seem to see any relevant changes in that PR you linked.

juhp commented 3 years ago

Ah, the changes are in the preceding commits (not mine), but there was no Hackage upload... :facepalm: So this was just an attempt to prepare a release for that.

juhp commented 3 years ago

I believe it is this change that requires a new release rather than a revision alas.

byorgey commented 3 years ago

Just for future reference, I found the relevant discussion here: https://github.com/hackage-trustees/malcolm-wallace-universe/issues/9 . Maybe it would be easiest just to set up your own fork. I'd be happy to help maintain it as well if you give me access.

juhp commented 3 years ago

Yes, nod, but how to do the import is my main stumbling block? Do we just fork malcolm-wallace-universe (probably confusing), or try to create a fresh git repo eg by importing Hackage releases, or just drop all history and start from current HEAD?

juhp commented 2 years ago

Okay Malcolm added me as a Hackage maintainer of HaXml this week: so I should be able to upload a new version soon. I am just wondering whether to make a HaXml org or even malcolm-wallace-universe (though probably not - my intention is just to help keep HaXml afloat as long as needed and possible). I hope you can join me (and others) there. :-)

byorgey commented 2 years ago

Re: what kind of org to make, if your intention is to just support HaXml, then better keep it to that for now! I will definitely join you there, ping me or post a link here!

juhp commented 2 years ago

Sure thing, thanks

juhp commented 2 years ago

https://github.com/HaXml/HaXml

juhp commented 2 years ago

I have released HaXml-1.25.6 on Hackage

Hopefully it can go into Stackage Nightly soon

juhp commented 2 years ago

Well maybe I closed prematurely, but I see you already enabled 9.0, thanks. So can we have a new release soon? :-)

byorgey commented 2 years ago

The latest release of haxr has now been revised on Hackage to build with GHC 9.0!

juhp commented 2 years ago

Yay, thanks!