byplayer / egg

Emacs Got Git. This is a clone of Marius's excellent magit. Egg is an emacs interface to git.
bogolisk.blogspot.com
97 stars 20 forks source link

Autoloads #45

Closed dotemacs closed 12 years ago

dotemacs commented 12 years ago

I think that SHA: 9ae5b190daa162e9bc67bc07e30254a35b168301 was created when there were Git version which were not compatible with Egg's approach.

The reason I created this pull request, is because when MELPA would create Egg package, it would create egg-autoloads.el which would be picked up on Emacs' start up. This is all fine, but because hooks where wrapped in in (when ...), they wouldn't be seen and in turn egg-minor-mode wouldn't be activated.

Please consider merging this in.

Thank you

dotemacs commented 12 years ago

Hi Byplayer,

any comment on the pull requests?

I'm wondering if they are not acceptable for some reason or if you're just under a lot of work and haven't had a chance to review them yet?

Thanks

dotemacs commented 12 years ago

Hello Byplayer,

the pull request was filed over two weeks ago. Any thoughts on it?

Thanks

byplayer commented 12 years ago

I'm sorry to be late merging. I merged it. Thank you.