Make PostalAddress wrap a simple 3-line address

byrokrat / giroapp

Command line app for managing autogiro donations.

GNU General Public License v3.0

4 stars 2 forks source link

Make PostalAddress wrap a simple 3-line address #105

Closed hanneskod closed 7 years ago

hanneskod commented 7 years ago

As it stands now it handles a dedicated c/o field and 2 regular lines. This is not how addresses are handled in the xml forms... For simplicity let's make addresses simple 3 line constructs.

At the same time consider

removing default values from constructor
normalize field names across the app (payerNumber => payer_number)
use alpha2 as schema version

nonbinary commented 7 years ago

I agree. On the actual online form, there is no specific c/o field either.

hanneskod commented 7 years ago

Cool. Will fix then...