search

byrokrat / giroapp

Command line app for managing autogiro donations.
GNU General Public License v3.0
4 stars 2 forks source link

dependencies for pr#12 #17

Closed nonbinary closed 7 years ago

nonbinary commented 7 years ago

shortened Donor->mandateKey to 16 digits, and added Donor->transactionDay

nonbinary commented 7 years ago

Since I'm terribly new to the git workflow, I suspect this should probably have been put in pr #12 . Hopefully I'll learn how to do that in the future.

hanneskod commented 7 years ago

Oh cool you already fixed this. Fast :) I'm leaving it open for now and you can see what I have come up with. Then we can decide further ahead..

hanneskod commented 7 years ago

By the way I don't think you can edit my pull requests. I can edit yours because you left a "let the repository owner edit" box checked when you created the pull. You can uncheck it if you want. And I probably shouldn't have edited anyway, as it is sort of rude I think. I just thought I could speed things up with some demonstrations. Will refrain from this in the future :)

nonbinary commented 7 years ago

Well, as I see it, we've got a bit of a teacher/pupil thing going on here, so it kinda seems logical for you to fix my pull requests :P

But ya, I say your hashId approach is probably better for this purpose. I'd say we go with that.

nonbinary commented 7 years ago

...And there's nothing in this pr that I feel we should use, so I'll see if I can figure out how to close it.