Fix optional xml mandate payernumber

byrokrat / giroapp

Command line app for managing autogiro donations.

GNU General Public License v3.0

4 stars 2 forks source link

Fix optional xml mandate payernumber #188

Closed nonbinary closed 5 years ago

nonbinary commented 5 years ago

This is how I would handle making the payer number optional, when importing xml files. But I also realize that the placement of the code is a philosophical issue, so not sure if it fits.

Does this seem reasonable?

hanneskod commented 5 years ago

Yes, good catch. Thanx! There were some conflicts between your suggestion and some things I was working on, so in the end I copied your changes instead of going through the hassle merging with upstream.. Pushed to master now..

nonbinary commented 5 years ago

Glad it was useful!