Let state id be class name constant

byrokrat / giroapp

Command line app for managing autogiro donations.

GNU General Public License v3.0

4 stars 2 forks source link

Let state id be class name constant #189

Closed hanneskod closed 5 years ago

hanneskod commented 5 years ago

Due to techinal debt donor states are represented (both in the database and internally) as string constants. This should be changed to class name constants from respective class. Change when we update all the state names. Affected places include:

Extensive use in ClassIdExtractor in state namespace.
Conversion in ForceStateHandler.
Double algorithm in StateCollection.
Setup in WorkflowConfigurator and donor_states.yaml.
Feature tests...

hanneskod commented 5 years ago

Updating from alpha5 to alpha6 requires a script that can process the json db. Let that script also remove al reduntant state_desc fields.