search

byrokrat / giroapp

Command line app for managing autogiro donations.
GNU General Public License v3.0
4 stars 2 forks source link

Imported files checksum #76

Closed nonbinary closed 6 years ago

nonbinary commented 7 years ago

Aiming at #36

nonbinary commented 7 years ago

I've backed away from checking the filenames to find a positive match. It would make the application a bit too sensitive to user routines, e.g if a company would like to rename all their past import files. This would make doubles invisible to the application. But I do feel that import date and filename are interesting in the error messages, so should be kept in the database.

nonbinary commented 7 years ago

Did I understand the priorities in /etc/container.yaml correctly?

hanneskod commented 7 years ago

The GitHub app in my phone is really bad for code review, will comment as soon as I am in front of a proper computer..

A note on priorities: the checksum listener should have a higher priority than the import listener, as a checksum failure should stop further import actions.

hanneskod commented 7 years ago

I agree about not checking file names.

nonbinary commented 7 years ago

I'll add tests now. I might to look through the last changes later, as well: has a bit of a cold. Not entirely sharp.

hanneskod commented 6 years ago

This has become sort of old. And as we are close to alpha2 I'm now implementing in another pr. See #137

Closing. Thanx for the work though! I did some copying of the code already written =)