Invalid here means not the same as recorded in the settings database.
InvalidNodeFilteringListener reads payee account numbers dispatches errors if the account does not match local settings. This is good but not enough:
It requires a NodeEvent to be fired, and that means that we need an actual mandate response node (or similar) for the check to be evaluated. But the payee account is present already in the opening node, and an error should be triggered by that! (Also note that byrokrat/autogiro already validates that payee accounts are constant within a tree (see Visitor/PayeeVisitor), so only the occurence in the opening node needs to be checked.)
To validate the customer number the opening node must be used.
See features-missing/import.feature for two tests that should pass.
InvalidNodeFilteringListener
reads payee account numbers dispatches errors if the account does not match local settings. This is good but not enough:NodeEvent
to be fired, and that means that we need an actual mandate response node (or similar) for the check to be evaluated. But the payee account is present already in the opening node, and an error should be triggered by that! (Also note thatbyrokrat/autogiro
already validates that payee accounts are constant within a tree (seeVisitor/PayeeVisitor
), so only the occurence in the opening node needs to be checked.)See
features-missing/import.feature
for two tests that should pass.