search

byronwall / bUTL

Excel add-in with helpers for charting, formatting, and general pain points
http://byroni.us/bUTL
MIT License
16 stars 3 forks source link

Integers to long, variable name standardization #49

Closed RaymondWise closed 8 years ago

byronwall commented 8 years ago

Thanks for putting this together. I should have some time today to review/merge.

RaymondWise commented 8 years ago

Sure thing. I just added one more thing if you want to put it in instead of me creating another pull request. Module UDFs error handling

Public Function RandLetters(numberOfLetters As Long) As String
    If numberOfLetters > 32767 Then
        If MsgBox("Cannot exceed 32,767 characters in one cell, please try again.", vbExclamation, "Exceeds maximum character limit for a single cell") = vbOK Then Exit Function
    End If
byronwall commented 8 years ago

I may have made a complete mess of things trying to get this merge completed. I think I got to the correct finish point, but I am pretty sure I took the wrong path to get there. I eventually did the merge by accepting all of your changes.

Thanks for going through and changing to longs and updating variables names. Getting things into camelCase will be a good starting point for making things more descriptive as we go forward.

I have all of this into master and merged. I think the bUTL.xlam file is in good shape. I will now go through and add the code that I have been working on to make sure that things go together. This may take a while.

Once all of that is done, I'll get a new release tagged so that we have a good "safe" spot going forward.

Sorry this took so long.