search

byronwall / bUTL

Excel add-in with helpers for charting, formatting, and general pain points
http://byroni.us/bUTL
MIT License
16 stars 3 forks source link

Class Module bUTLChartSeries #51

Closed RaymondWise closed 7 years ago

RaymondWise commented 8 years ago

I made changes to the class module only, I'm not sure why the other files are showing changes. I can't find any actual differences in the two with large chunks "changed"

RaymondWise commented 8 years ago

First commit was renaming variables in the class module. Second commit is making all procedures public if they aren't declared private. I tried finding references and definitions of the procedures so some could change to private, but it wasn't working. I had to trash that attempt and recompile.

RaymondWise commented 8 years ago

Third commit - fixed a lot of arguments not being passed ByVal. Removed instances of multiple declarations on one line to multiple lines.

https://github.com/byronwall/bUTL/issues/53 Identified and commented on variables that don't appear to be used

Variable Module
Variable 'rangeColumn' is never assigned bUTLAddIn.Chart_Processing
Variable 'ButlSeriesies' is never used bUTLAddIn.Chart_Series
Variable 'int_left' is never used bUTLAddIn.RandomCode
Variable 'int_top' is never used bUTLAddIn.RandomCode
Variable 'rangeColumn' is never used bUTLAddIn.Chart_Processing

https://github.com/byronwall/bUTL/issues/54 Identified three variants that I imagine could be strings instead, but did not change them

Variable Module
Variable 'folder' bUTLAddIn.RandomCode
Variable 'path' bUTLAddIn.RandomCode
Variable 'str_folder' bUTLAddIn.RandomCode

Had a few things I was wondering about

https://github.com/byronwall/bUTL/issues/55 Function Download_File I don't see this returning any values, so maybe it should be a sub?

https://github.com/byronwall/bUTL/issues/52 All of the Ribbon_Callbacks have an argument like control - why? I'm sure they are needed, but I don't see what they are doing, pardon my ignorance.