byronwall / bUTL

Excel add-in with helpers for charting, formatting, and general pain points
http://byroni.us/bUTL
MIT License
16 stars 3 forks source link

Declared variants can be strings #54

Open RaymondWise opened 8 years ago

RaymondWise commented 8 years ago

Re: https://github.com/byronwall/bUTL/pull/51#issuecomment-209568652

These variables may be able to be declared as strings rather than variants

Variable Module
Variable 'folder' bUTLAddIn.RandomCode
Variable 'path' bUTLAddIn.RandomCode
Variable 'str_folder' bUTLAddIn.RandomCode
byronwall commented 8 years ago

I suspect they can be strings as well. The RandomCode section of the add-in is a little bit of the wild west. I think it should be properly buried if the code can't be justified in another module. That code came through from things that I assumed would be useful someday. I think that assumption may not prove out.

In the short term, we can clean this code up to make it consistent with best practices. In the long term, this code may not be useful or worth keeping in the add-in.