search

byronwall / bUTL

Excel add-in with helpers for charting, formatting, and general pain points
http://byroni.us/bUTL
MIT License
16 stars 3 forks source link

Function Download_File doesn't seem to return a value #55

Closed RaymondWise closed 7 years ago

RaymondWise commented 8 years ago

Functions should be used to return something whereas subs should be used to do something. The Function Download_File does not appear to return a value and may be better as a sub.

byronwall commented 8 years ago

I agree that if there is no return then then it should be a Sub. Sometimes it's easier to create a Function that might return something than a Sub that cannot.

RaymondWise commented 8 years ago

If you prefer the function, go ahead and close this as non-issue. It doesn't bother me, just thought I'd point it out since I saw it.