search

byronwall / bUTL

Excel add-in with helpers for charting, formatting, and general pain points
http://byroni.us/bUTL
MIT License
16 stars 3 forks source link

mostly variable names #61

Closed RaymondWise closed 8 years ago

RaymondWise commented 8 years ago

Improved naming on all standard modules except random code. Put in some select case, changed some if blocks, created constants for using in case changes needed. Added some comments, raised some issues on github.

byronwall commented 8 years ago

This is great. Thanks for taking the time to go through these once more. I like the targetObject targetSeries etc. I also like all the constants being called out explicitly instead of just having magic numbers down in the code. This has been merged in. I added one commit after yours to get rid of code that referencing Powerpoint. It was in the Testing section and was not worth the reference.

RaymondWise commented 8 years ago

Ha! I managed to pull down the upstream and rebase my version successfully, yay.