search

byroot / activerecord-typedstore

ActiveRecord::Store but with type definition
MIT License
439 stars 57 forks source link

Fail tests for dirty tracking type casting #19

Closed kmcphillips closed 10 years ago

kmcphillips commented 10 years ago

@byroot @qq99

These tests show this failure:

[12] pry> shop.password_enabled?
=> false
[13] pry> shop.password_enabled = "false"
=> "false"
[14] pry> shop.password_enabled?
=> false
[15] pry> shop.password_enabled_changed?
=> true
byroot commented 10 years ago

LGTM. I'll submit the fix directly on master

byroot commented 10 years ago

Should be fixed by https://github.com/byroot/activerecord-typedstore/commit/9103a3a1892fc5c2f152da06c29b54a0f1fff60c

qq99 commented 10 years ago

So the test are currently failing? Not sure how this PR fixes typedstore

kmcphillips commented 10 years ago

This PR doesn't fix. Just shows failure. Fix is on master. https://github.com/byroot/activerecord-typedstore/commit/9103a3a1892fc5c2f152da06c29b54a0f1fff60c

qq99 commented 10 years ago

Ohh gotcha