byroot / activerecord-typedstore

ActiveRecord::Store but with type definition
MIT License
439 stars 57 forks source link

fix cast_type nil::NilClass when calling write_attribute with a symbol #27

Closed dannytip closed 9 years ago

dannytip commented 9 years ago

Fixes #26

byroot commented 9 years ago

Did you tried to write a regression test?

Otherwise LGTM.

dannytip commented 9 years ago

Having issues running the test suite currently but i'm working on it.

dannytip commented 9 years ago

Test added apologies if they are in the wrong place but the tests fail before my fix and pass after..

byroot commented 9 years ago

No that fine. I'll change the wording a bit and ship a new version in a couple minutes. Thanks a lot!

byroot commented 9 years ago

A 0.5.1 have been released. Thanks again for your contribution.

dannytip commented 9 years ago

No problem at all. Thanks for releasing the fix so fast.