[WIP] A new version that target Rails 4.2+ - Githubissues

byroot / activerecord-typedstore

ActiveRecord::Store but with type definition

MIT License

439 stars 57 forks source link

[WIP] A new version that target Rails 4.2+ #32

Closed yesmeck closed 8 years ago

yesmeck commented 9 years ago

[x] Remove all compatibility code
[ ] Use new ActiveRecord API

yesmeck commented 9 years ago

Hi @byroot , I create this WIP PR early so that you can review my code, give me some advice (if you have any time).

byroot commented 9 years ago

Sure. Please ping me back when you have a prototype.

yesmeck commented 9 years ago

@byroot Do you have any thoughts about the new version that I can add them to the checklist?

coveralls commented 9 years ago

Coverage decreased (-0.51%) to 97.86% when pulling a9e08dc85688e03114e83acc8812f9ec8c378ed3 on yesmeck:rails-4.2 into 062b430284c0ace96fc6270570ce2655b34c0566 on byroot:master.

coveralls commented 9 years ago

Coverage decreased (-0.51%) to 97.86% when pulling a9e08dc85688e03114e83acc8812f9ec8c378ed3 on yesmeck:rails-4.2 into 062b430284c0ace96fc6270570ce2655b34c0566 on byroot:master.

byroot commented 9 years ago

Not really. But I would recommend to start fresh by totally removing the extension.rb file. And of course to take a good look at how store is now implemented in Rails.

coveralls commented 9 years ago

Coverage decreased (-0.51%) to 97.86% when pulling a9e08dc85688e03114e83acc8812f9ec8c378ed3 on yesmeck:rails-4.2 into 062b430284c0ace96fc6270570ce2655b34c0566 on byroot:master.

coveralls commented 9 years ago

Coverage decreased (-1.78%) to 96.59% when pulling e6073164c34b80842359ced18986086e60b64fa0 on yesmeck:rails-4.2 into 062b430284c0ace96fc6270570ce2655b34c0566 on byroot:master.

coveralls commented 9 years ago

Coverage decreased (-1.78%) to 96.59% when pulling e6073164c34b80842359ced18986086e60b64fa0 on yesmeck:rails-4.2 into 062b430284c0ace96fc6270570ce2655b34c0566 on byroot:master.