Closed kirs closed 8 years ago
I got both gem and Shopify app CI green. I think it's good to merge. Would be great if you guys can review it. /cc @byroot @rafaelfranca @sgrif
@byroot thanks for review! I fixed all issues addressed in your comments.
Code LGTM at this point. If CI is :green_apple: I'm :+1:. But let's wait on either @rafaelfranca or @sgrif
I just recalled the reason why I didn't use ActiveRecord::Type.lookup
initially. The reason is that it required database connection. And for Shopify app, we should to be able to start the app without database connection.
@rafaelfranca thanks for review! I fixed all things except for what we discussed about type map.
:shipit:
Released as 1.0.0.beta1
ActiveRecord::Type