byroot / activerecord-typedstore

ActiveRecord::Store but with type definition
MIT License
439 stars 57 forks source link

Rails 5 #40

Closed kirs closed 8 years ago

kirs commented 8 years ago
kirs commented 8 years ago

I got both gem and Shopify app CI green. I think it's good to merge. Would be great if you guys can review it. /cc @byroot @rafaelfranca @sgrif

kirs commented 8 years ago

@byroot thanks for review! I fixed all issues addressed in your comments.

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling 046c49b79f5f16656e3b5e7bec1baa762a358bf8 on kirs:rails-five-green into \ on byroot:master**.

byroot commented 8 years ago

Code LGTM at this point. If CI is :green_apple: I'm :+1:. But let's wait on either @rafaelfranca or @sgrif

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling 046c49b79f5f16656e3b5e7bec1baa762a358bf8 on kirs:rails-five-green into \ on byroot:master**.

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling 5a0237ac72aa6443637fc7d55b3a62bc5c565973 on kirs:rails-five-green into \ on byroot:master**.

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling 1f41b79c569599ccc1fc6a9f9d48c1f966915d02 on kirs:rails-five-green into \ on byroot:master**.

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling bdcb36c11a71954ca68da29ddbb2d2cf2c7a0c4d on kirs:rails-five-green into \ on byroot:master**.

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling 2f5d147136e5ce5c8500b50b8589da777e16ae0d on kirs:rails-five-green into \ on byroot:master**.

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling ab98c373261b3b270e55a863ae0281f76beb042d on kirs:rails-five-green into \ on byroot:master**.

kirs commented 8 years ago

I just recalled the reason why I didn't use ActiveRecord::Type.lookup initially. The reason is that it required database connection. And for Shopify app, we should to be able to start the app without database connection.

@rafaelfranca thanks for review! I fixed all things except for what we discussed about type map.

rafaelfranca commented 8 years ago

:shipit:

byroot commented 8 years ago

Fix: https://github.com/byroot/activerecord-typedstore/issues/34 Fix: https://github.com/byroot/activerecord-typedstore/issues/24

byroot commented 8 years ago

Released as 1.0.0.beta1