search

byroot / activerecord-typedstore

ActiveRecord::Store but with type definition
MIT License
441 stars 57 forks source link

Include IdentityCoder by default #65

Closed dwightwatson closed 6 years ago

dwightwatson commented 6 years ago

This is a simple change but it includes the DumbCoder out of the box, so projects that use it don't need to maintain that class as well. It appears as though there is precedent for this - In #35 and #38 it looks like it was included and could be enabled by setting coder: false. Later on in 051ab0396e266b40ef6859c8ca9e5bd7ae79acb5 it was renamed from DumbCoder to IdentityCoder.

This change doesn't impact the default options - it doesn't restore the feature where you would do coder: false to get it using this coder. If you want to use it you will need to be explicit about it, but at least it's available out-of-the-box. Means it's much easier to pick up and get going when using a HStore or JSON column type.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 94.917% when pulling 41095decd1e6c2f71e3008b281906d28ede7204a on dwightwatson:feature/identity-coder into 97283a5943a8fe712a7d4ac3317851e5b82f7dd6 on byroot:master.