They are already listed in the .gemspec development dependencies
Remove the upperbound constraint on ActiveRecord:
During every ActiveRecord bump, this gemspec needs to be updated,
I think we are being too conservative and having an upperbound limit
doesn't help.
If we wanted to be really conservative we would have to add a
upperbound constraint on the minor version as well (< 5.x.x) since
Rails doesn't follow semver and minor version can introduce breaking
changes.
What I think is better is to remove the upperbound constraint,
and test AM directly on ActiveRecord edge
Coverage remained the same at 94.932% when pulling 621a4e995ce53339b1464490d2a2738e7017d500 on Edouard-chin:ec-ar-upperbound-constraint into 086965128287cc889915aeb49b832c8766bc5446 on byroot:master.
Coverage remained the same at 94.932% when pulling 621a4e995ce53339b1464490d2a2738e7017d500 on Edouard-chin:ec-ar-upperbound-constraint into 086965128287cc889915aeb49b832c8766bc5446 on byroot:master.
Coverage remained the same at 94.932% when pulling 621a4e995ce53339b1464490d2a2738e7017d500 on Edouard-chin:ec-ar-upperbound-constraint into 086965128287cc889915aeb49b832c8766bc5446 on byroot:master.
Coverage remained the same at 94.932% when pulling 621a4e995ce53339b1464490d2a2738e7017d500 on Edouard-chin:ec-ar-upperbound-constraint into 086965128287cc889915aeb49b832c8766bc5446 on byroot:master.
Coverage remained the same at 94.932% when pulling 095b4a4acdc649d9e8c4ddc2d69e6c1fbad6030a on Edouard-chin:ec-ar-upperbound-constraint into 086965128287cc889915aeb49b832c8766bc5446 on byroot:master.
Coverage remained the same at 94.932% when pulling 621a4e995ce53339b1464490d2a2738e7017d500 on Edouard-chin:ec-ar-upperbound-constraint into 086965128287cc889915aeb49b832c8766bc5446 on byroot:master.
Coverage remained the same at 94.932% when pulling 621a4e995ce53339b1464490d2a2738e7017d500 on Edouard-chin:ec-ar-upperbound-constraint into 086965128287cc889915aeb49b832c8766bc5446 on byroot:master.
Coverage remained the same at 94.932% when pulling 621a4e995ce53339b1464490d2a2738e7017d500 on Edouard-chin:ec-ar-upperbound-constraint into 086965128287cc889915aeb49b832c8766bc5446 on byroot:master.
Coverage remained the same at 94.932% when pulling 621a4e995ce53339b1464490d2a2738e7017d500 on Edouard-chin:ec-ar-upperbound-constraint into 086965128287cc889915aeb49b832c8766bc5446 on byroot:master.
Remove development dependencies from Gemfiles:
.gemspec
development dependenciesRemove the upperbound constraint on ActiveRecord:
During every ActiveRecord bump, this gemspec needs to be updated, I think we are being too conservative and having an upperbound limit doesn't help.
If we wanted to be really conservative we would have to add a upperbound constraint on the minor version as well (< 5.x.x) since Rails doesn't follow semver and minor version can introduce breaking changes.
What I think is better is to remove the upperbound constraint, and test AM directly on ActiveRecord edge