byroot / activerecord-typedstore

ActiveRecord::Store but with type definition
MIT License
437 stars 57 forks source link

Add support for prefix and suffix options #91

Closed dwillett closed 2 years ago

dwillett commented 2 years ago

Adds support for prefix and suffix options similar to the options exposed for store

dwillett commented 2 years ago

I'm realizing that this approach doesn't really work since it actually changes the attribute name passed to store_accessor. I think I was right in the description, that it would need to pass the options through. Will take another pass at it.

dwillett commented 2 years ago

@byroot This should be ready for review now (with a revised approach) when you get a chance

casperisfine commented 2 years ago

Arf, looks like CI is busted -_-

casperisfine commented 2 years ago

Arf, looks like CI is busted -_-

I fixed it on master, you'll have to rebase though.

dwillett commented 2 years ago

Thanks - rebased and should be ready for another CI check

byroot commented 2 years ago

Can you please squash all your commits into one? After than I can merge.

dwillett commented 2 years ago

Sure thing, squashed and ready

casperisfine commented 2 years ago

Thanks!

stellar-geoff commented 2 years ago

👋 @casperisfine @byroot @dwillett Thanks for this PR, its just what I was looking for. It looks like this was merged but hasn't been included in a published version. Any chance you could publish a new one to rubygems? Thanks again either way