search

byroot / pysrt

Python parser for SubRip (srt) files
GNU General Public License v3.0
449 stars 67 forks source link

Include tests into releases #42

Closed Nikoli closed 8 years ago

Nikoli commented 10 years ago

Please include tests into releases, Gentoo python packages run them before installing.

byroot commented 10 years ago

I tried, but all I was able to do is to not include them.

I would accept a PR though.

sbraz commented 8 years ago

Hi, I just tried running python setup.py sdist and the tests are included in the resulting tarball. Could it be that you use a MANIFEST.in that is not present in the git repo?

byroot commented 8 years ago

I don't have any MANIFEST.in.

$ python setup.py sdist
running sdist
running egg_info
writing requirements to pysrt.egg-info/requires.txt
writing pysrt.egg-info/PKG-INFO
writing top-level names to pysrt.egg-info/top_level.txt
writing dependency_links to pysrt.egg-info/dependency_links.txt
writing entry points to pysrt.egg-info/entry_points.txt
reading manifest file 'pysrt.egg-info/SOURCES.txt'
writing manifest file 'pysrt.egg-info/SOURCES.txt'
running check
creating pysrt-1.0.1
creating pysrt-1.0.1/pysrt
creating pysrt-1.0.1/pysrt.egg-info
making hard links in pysrt-1.0.1...
hard linking README.rst -> pysrt-1.0.1
hard linking setup.py -> pysrt-1.0.1
hard linking pysrt/__init__.py -> pysrt-1.0.1/pysrt
hard linking pysrt/commands.py -> pysrt-1.0.1/pysrt
hard linking pysrt/comparablemixin.py -> pysrt-1.0.1/pysrt
hard linking pysrt/compat.py -> pysrt-1.0.1/pysrt
hard linking pysrt/srtexc.py -> pysrt-1.0.1/pysrt
hard linking pysrt/srtfile.py -> pysrt-1.0.1/pysrt
hard linking pysrt/srtitem.py -> pysrt-1.0.1/pysrt
hard linking pysrt/srttime.py -> pysrt-1.0.1/pysrt
hard linking pysrt/version.py -> pysrt-1.0.1/pysrt
hard linking pysrt.egg-info/PKG-INFO -> pysrt-1.0.1/pysrt.egg-info
hard linking pysrt.egg-info/SOURCES.txt -> pysrt-1.0.1/pysrt.egg-info
hard linking pysrt.egg-info/dependency_links.txt -> pysrt-1.0.1/pysrt.egg-info
hard linking pysrt.egg-info/entry_points.txt -> pysrt-1.0.1/pysrt.egg-info
hard linking pysrt.egg-info/requires.txt -> pysrt-1.0.1/pysrt.egg-info
hard linking pysrt.egg-info/top_level.txt -> pysrt-1.0.1/pysrt.egg-info
Writing pysrt-1.0.1/setup.cfg
Creating tar archive

Honestly I don't do much python these days, so I'm not very familiar with the packaging solutions.

EdwardBetts commented 8 years ago

Pull request: #59

byroot commented 8 years ago

I released a 1.1.1 that includes the test. Thanks everybody.