search

byroot / pysrt

Python parser for SubRip (srt) files
GNU General Public License v3.0
454 stars 69 forks source link

Add duration attribute to SubRipItem #45

Closed felagund closed 10 years ago

felagund commented 10 years ago

You mean like this? This seems to work and changes when I shift the subtitle.

byroot commented 10 years ago

Yes like this. Also please remove duration from the class documentation since it's not a constructor argument or anything.

I'd also like to add tests before merging. Otherwise LGTM.

felagund commented 10 years ago

Ok, so this should be fine then? The test passes on my machine and I hope it is extensive enough.

byroot commented 10 years ago

Please revert the version change, then I'll merge.

felagund commented 10 years ago

Damn, that was completely unintentional, no idea how it got there, I will fix that.

felagund commented 10 years ago

It should be fine now.

byroot commented 10 years ago

Nope, It's still there.

felagund commented 10 years ago

I do not understand this at all. Changing the version to 1.0.1 was you last commit, right? I do not know why it shows up here. I tried to use the online editor here, but it added two more commits and it changes version to 1.0.0 - but it should already be 1.0.1, no? And this: https://github.com/felagund/pysrt/commit/a92e2b757e73d85cf699d73e56c8f6b06586af1b does not show it at all:-/.

byroot commented 10 years ago

Hum right, something is weird. I'll merge this manually soon to avoid any bad surprise.

Thanks for your contribution.