byroot / pysrt

Python parser for SubRip (srt) files
GNU General Public License v3.0
446 stars 67 forks source link

srt: generate unique name for backup file #73

Open schdub opened 6 years ago

schdub commented 6 years ago

If .bak file exist, then its contents are taken as the source file.

reproducing the error situation

# source file contents
$ cat 1.srt
1
00:00:01,111 --> 00:00:03,646
Line 1

2
00:00:07,569 --> 00:00:10,058
Line 2

# good
$ srt -i shift -10ms 1.srt && cat 1.srt
1
00:00:01,101 --> 00:00:03,636
Line 1

2
00:00:07,559 --> 00:00:10,048
Line 2

# fail
$ srt -i shift -10ms 1.srt && cat 1.srt
1
00:00:01,101 --> 00:00:03,636
Line 1

2
00:00:07,559 --> 00:00:10,048
Line 2

# fail
$ srt -i shift -20ms 1.srt && cat 1.srt
1
00:00:01,091 --> 00:00:03,626
Line 1

2
00:00:07,549 --> 00:00:10,038
Line 2

My solution is generate unique name for bak file.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.4%) to 70.876% when pulling bfc452f83573d7dd9995aeda37007f3aaa605bf5 on schdub:master into e23ca39de37d54e988f4726c311aee4d4770c2ca on byroot:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.4%) to 70.876% when pulling bfc452f83573d7dd9995aeda37007f3aaa605bf5 on schdub:master into e23ca39de37d54e988f4726c311aee4d4770c2ca on byroot:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.4%) to 70.876% when pulling bfc452f83573d7dd9995aeda37007f3aaa605bf5 on schdub:master into e23ca39de37d54e988f4726c311aee4d4770c2ca on byroot:master.