search

byroot / pysrt

Python parser for SubRip (srt) files
GNU General Public License v3.0
446 stars 67 forks source link

open(): don't use universal 'U' mode #80

Closed vstinner closed 4 years ago

vstinner commented 4 years ago

The open() 'U' mode has been removed from Python 3.9.

vstinner commented 4 years ago

Tests still pass on Python 2.7 and 3.9: I tested manually on Linux.

byroot commented 4 years ago

Thanks.

vstinner commented 4 years ago

FASTEST MERGE EVER! Thank you :-) That's was blazing fast!

byroot commented 4 years ago

Happy accident I guess.

If it's outright broken on new versions I'll see about cutting a new release.

byroot commented 4 years ago

I'll see about cutting a new release.

Ok, I had a bit of a hard time figuring out the new tools, but in the end 1.1.2 is out.

Since you are up to date with Python (whereas I'm really not anymore), would be nice if you could confirm me I didn't bork the release.

vstinner commented 4 years ago

Oh, I forgot the link to the Fedora downstream issue: https://bugzilla.redhat.com/show_bug.cgi?id=1793011

vstinner commented 4 years ago

Since you are up to date with Python (whereas I'm really not anymore), would be nice if you could confirm me I didn't bork the release.

The Fedora package has been updated with success: https://bugzilla.redhat.com/show_bug.cgi?id=1793011