byt3bl33d3r / CrackMapExec

A swiss army knife for pentesting networks
BSD 2-Clause "Simplified" License
8.37k stars 1.64k forks source link

ImportError: cannot import name 'highlight' from 'helpers' #404

Closed 3isenHeiM closed 4 years ago

3isenHeiM commented 4 years ago

Describe the bug ImportError: cannot import name 'highlight' from 'helpers'

To Reproduce Steps to reproduce the behavior:

  1. Clone the repo
  2. cd into it
  3. Install it using pipenv as recommended by the wiki : pipenv install
  4. Enter the pipenv : pipenv shell
  5. Try to launch CME : cme --help

Expected behavior CME should start and display the help

Crackmapexec info

Additional context Here is the traceback of the error :

Traceback (most recent call last):
  File "/home/x/.local/bin/cme", line 5, in <module>
    from cme.crackmapexec import main
  File "/home/x/.local/lib/python3.8/site-packages/cme/crackmapexec.py", line 10, in <module>
    from cme.connector import connector
  File "/home/x/.local/lib/python3.8/site-packages/cme/connector.py", line 6, in <module>
    from cme.connection import Connection
  File "/home/x/.local/lib/python3.8/site-packages/cme/connection.py", line 3, in <module>
    from helpers import highlight
ImportError: cannot import name 'highlight' from 'helpers' (/home/x/.local/lib/python3.8/site-packages/helpers/__init__.py)

Python helpers version (from pip): helpers-0.2.0

3isenHeiM commented 4 years ago

Added screenshot for reference.

Screenshot from 2020-07-20 14-33-58

m4m00th commented 4 years ago

The same problem

mpgn commented 4 years ago

Sorry guys, but I cannot reproduce the error.

Also, you don't need to use pipenv for installing cme maybe that the issue.

3isenHeiM commented 4 years ago

Excuse me, but quoting the installation manual :

It is highly reccomended to use pipenv to install CME so it's dependencies don't create conflicts with your system packages.

IMHO this is a lack of coherence. Can you reproduce the bug by installing CME inside a pipenv ? Indeed we don't want to break other dependencies so a pipenv is mandatory.

mpgn commented 4 years ago

I fix the doc, should be good now 👍

nightfuryGitHub commented 1 year ago

same problem