byt3bl33d3r / CrackMapExec

A swiss army knife for pentesting networks
BSD 2-Clause "Simplified" License
8.45k stars 1.64k forks source link

Help/Usage dialogs incorrectly place positional argument #576

Closed GeneralBison closed 2 years ago

GeneralBison commented 2 years ago

Describe the bug The help/usage dialogs incorrectly show [target(s)] as a positional parameter at the end of the command. Currently having the target positionally at the end, it is interpreted as part of the previous parameter.

To Reproduce Steps to reproduce the behavior:

  1. run crackmapexec mssql -u foo -p bar 127.0.0.1

Expected behavior CrackMapExec will attempt to authenticate to MSSQL on 127.0.0.1 with the username foo and the password bar

Screenshots image image

Crackmapexec info

Additional context

wlayzz commented 2 years ago

Hey ! It's just the way argparse print positional argument in the help message but you can use it like this : crackmapexec mssql 127.0.0.1 -u foo -p bar or crackmapexec mssql -u foo -p bar -- 127.0.0.1