byt3bl33d3r / DeathStar

Uses Empire's (https://github.com/BC-SECURITY/Empire) RESTful API to automate gaining Domain and/or Enterprise Admin rights in Active Directory environments using some of the most common offensive TTPs.
GNU General Public License v3.0
1.57k stars 331 forks source link

It's threaded but doesn't seem to be working in parallel #52

Closed DanMcInerney closed 3 years ago

DanMcInerney commented 6 years ago

It seems like the pwn_the_shit_outta_everything function is just performing its duties as if it weren't multithreaded at all. It hits the spread_threads then those threads take control and do their thing while pwn_the_shit_outta_everything seems to wait and not move on. It doesn't seem like blocking code though from looking at it. Any idea if I'm just imagining things?

byt3bl33d3r commented 6 years ago

I noticed this too. The only explanation I have is that somewhere along the line blocking calls are being made. Hence why I sorta want to rewrite the whole thing using asyncio.

I might just do that now since you fixed everything lol