byt3bl33d3r / WitnessMe

Web Inventory tool, takes screenshots of webpages using Pyppeteer (headless Chrome/Chromium) and provides some extra bells & whistles to make life easier.
GNU General Public License v3.0
734 stars 109 forks source link

Adding --no-sandbox param to the pyppeteer #3

Closed mdisec closed 5 years ago

mdisec commented 5 years ago

When you try to run witness me with root user, pyppeteer will be ignoring to initiate chrome process. In order to avoid from that, we gotta pass args=['--no-sandbox'] to launch() function.

https://github.com/byt3bl33d3r/WitnessMe/blob/c8086041a418026b1b4b13afeb253ee6cdcef188/witnessme.py#L139

I do propose following fix. I've tested it on locally.

browser = await pyppeteer.launch(headless=True, ignoreHTTPSErrors=True, args=['--no-sandbox'])
mdisec commented 5 years ago

Actually #2 related with that issue.

korang commented 5 years ago

The fix above worked for me

byt3bl33d3r commented 5 years ago

Ah, I never ran it with root privs. That explains why I didn't run into this. Thanks, I'll push a fix soon.

byt3bl33d3r commented 5 years ago

Done. Thanks