Closed byt3bl33d3r closed 4 years ago
Wow so apparently installing pyppeteer from the dev branch:
python3 -m pip install -U git+https://github.com/miyakogi/pyppeteer.git@dev
plus applying the fix detailed here https://github.com/miyakogi/pyppeteer/pull/160#issuecomment-448886155 (which WitnessMe already does to solve another websocket timeout issue) seems to have solved the above error at least.
Ok, so doing the above seems to have at least fixed the error so the entire thing doesn't crash. However now it seems like after ~1k screenshots everything just stops. No errors, just everything starts timing out for some reason. Fun.
And I take everything back. Looks like even with the dev version things crash. FML
Any solutions to this yet? WitnessMe is unusable for me because of this issue
Its an issue with the underlying pyppeteer library, I definitely don't have the bandwith to see if I can fix it. You're more then welcome to dig into it and submit a PR :)
Ok so the only way around this bug that I've managed to figure out is to open and close Chrome after a batch of screenshots have been taken (which is determined by the --threads
argument).
Commit e1b5ec1 does exactly this. So after 25 screenshots (by default) it will open and close Chrome for you automatically and keep scanning. This way the above error is avoided.
I'm closing this since this seems to be somewhat resolved as of v1.5.0.
So apparently, there's yet another websocket connection bug in pyppeteer. Seems that after 400ish screenshots the connection to chrome just dies. :( https://github.com/miyakogi/pyppeteer/issues/149
Tried some of the proposed fixes but none of them worked for me.