Closed Garados007 closed 1 year ago
@t-b @MichaelHuth Ready for review.
@MichaelHuth I have changed it in that way that it will call ReportErrorAndAbort
if I get an invalid wave back from the data generator. This will report the error and stops executing RunTest without any writing JUnit or TAP output. This should be the same behavior as before if I am right.
The other idea with collecting the errors and printing JUnit only for the failed data generator suite is quite interesting but has some problems:
setAbortFlag()
for this but I have to catch it at some point and I don't know if it will have some weird side effects.
@MichaelHuth Please re-review this.
Assigning @MichaelHuth as I think this was the intention.
@MichaelHuth Ready for review.
@MichaelHuth Just to be sure that this works now: Did you try to run one MIES hardware test with this PR?
I did not wrote that it works now. I was about to do some MIES tests as final test.
@Garados007 It turns out that the setup for test cases for the data generators is not complete as I get an IUTF internal RTE when using an assertion in a data generator function from a non-existing igor_debug_assertion
in DebugFailedAssertion
.
If the global is created the MIES HW tests start running...
I did not wrote that it works now. I was about to do some MIES tests as final test.
Thanks, sorry for being impatient.
I have refactored the debug helper methods into their own file. This allowed me to copy the set/reset of the Igor Debugger from regular test cases to the data generators. During this fixed also the bug with the non-existent igor_debug_assertion
as it is always created before each data generator execution.
@MichaelHuth Ready for review.
Thanks both!
Each data generator is now wrapped as a virtual test case which is also reported into the test results. To achieve this the setup for data generator has been changed into three phases:
Close #353
This PR does also consists of two refactoring steps. In one refactoring commit are all data generator, multi data and multi-multi data test related functions moved in their own file which reduces the size and complexity of UTF_Basics a lot. The second refactoring commit moves some polyfill methods into their own file.