search

bytebeamio / rumqtt

The MQTT ecosystem in rust
Apache License 2.0
1.53k stars 234 forks source link

rumqttc - ack with reason code #841

Open ting-ms opened 2 months ago

ting-ms commented 2 months ago

Does rumqttc support replay ack with a reason code?

swanandx commented 2 months ago

Hey, rumqttc doesn't support it right now, but would be nice to have!

also there is #609 , I'm thinking we can modify ack fn to take Ack as suggested in issue description, wdyt?

Thank you so much!

ting-ms commented 2 months ago

If we are going to add a new API such as get_ack_packet(&Publish) -> Ack, we could consider adding additional parameters, such as PubAckReason and PubAckProperties, and then modify the ack function to accept Ack as its argument.

xiaocq2001 commented 2 months ago

Proposed some solution with ack packet, please check: https://github.com/bytebeamio/rumqtt/pull/855