bytechefhq / bytechef

Open-source, low-code, extendable API integration & workflow automation platform. Integrate your organizations or your SaaS product with any third party API
https://www.bytechef.io
Other
220 stars 51 forks source link

[bug]: filter by label, not value #1274

Open marko-kriskovic opened 4 months ago

marko-kriskovic commented 4 months ago

Describe the bug

When I try to filter a search bar, it filters by value instead of label.

Screenshot from 2024-07-25 13-58-16 Screenshot from 2024-07-25 13-58-27

Steps To Reproduce

  1. add OpenAi component
  2. Go to Create transcriptions Action
  3. click on Language search bar
  4. if you type in 'hr': nothing should be shown, instead of Croatia
  5. if you type in 'cr': Croatia should be shown, instead of nothing

Expected behavior

Filtering by label makes more sense.

Version

latest

OS

ubuntu

Browser

No response

Additional context

No response

F1nn-T commented 4 months ago

Hey @marko-kriskovic, you can assigne me here as well :)

F1nn-T commented 4 months ago

There is already an open discussion on the cmdk GitHub repo. https://github.com/pacocoursey/cmdk/discussions/195

I have currently found only two ways to fix this error:

  1. Remove the value, so the label is used for searching and taken as the value.
  2. Add a custom search/filter.

Both ways don't sound very good to me. If you have any ideas, let me know :)

kresimir-coko commented 1 month ago

Hey @F1nn-T I haven't seen this ticket yet, sorry for that. Feel free to ping me for any frontend related questions (I might have been on PTO during the time of this ticket)

I wanted to just say that we don't use cmdk here but radix instead. I assume you know that seeing that you did some work on our ComboBox component. I'm just pointing it out because you're linking cmdk docs.


This bug does seem like a noticeable problem though, you'd expect to be able to filter by the values that you are seeing in the dropdown. Let me know if you can provide more insight, otherwise I'll pick up the ticket and fix it at some other point in time.

kresimir-coko commented 1 month ago

@F1nn-T any updates?