fix: truly respect `--allow-all` to allow all components

bytecodealliance / WASI-Virt

Virtual implementations of WASI APIs

Apache License 2.0

144 stars 17 forks source link

fix: truly respect `--allow-all` to allow all components #61

Closed kateinoigakukun closed 5 months ago

kateinoigakukun commented 5 months ago

ArgAction::SetTrue is not the right action for allow_xxx options, as they should default to None instead of Some(false) when the option itself is not specified. The wrong default value led to the --allow-all option not being respected, as the allow_xxx.unwrap_or(allow_all) always ignored the allow_all value.

guybedford commented 5 months ago

Amazing, thanks for spotting that one.