Closed ydnar closed 9 months ago
thank you so much for the PR (and all the work you do for open source community).
if you have a few mins, could you please add a testcase in https://github.com/bytecodealliance/actions/blob/main/.github/workflows/wasmtools-tests.yml for the new wasm-tools format. (or I am happy to add it myself in a follow up PR).
I’m happy to update this to have wasmtime accept a bare version without the v prefix.
what do you think would be better: to accept version without v prefix or update actions to support both formats (with/without prefix) to avoid any confusions.
thanks
Thanks for making this! I have a few projects that use it—it’s been handy to have an official setup action for wasmtime
, wasm-tools
, and wit-bindgen
.
OK, tests pass. I rebased and squashed.
Would it make sense to bump the release to v1.1
after this is merged?
I can update the README to reflect that and the changes to the accepted version spec.
Hi @ydnar , thank you for making the changes and adding the tests.
given these changes are backward compatible (please correct me I misread this), I think we can just make a patch release.
In anycase, for v1.x.y
, we will move tag v1
to point to latest release automatically (this is the norm I have seen in other actions), so it should be fine either way.
Thanks
Please let me know if you have opinion about patch vs minor release, and I will cut the new release accordingly. thanks again.
It's backwards compatible as far as I can tell from the tests. Any version is probably fine.
Do you want to update the README?
yeah, that would be great. thank you.
Done!
Fixes #8.
v1.0.0
or1.0.0