bytecodealliance / actions

GitHub actions to setup wasm-tools and wasmtime
5 stars 3 forks source link

wasm-tools: load new tag format #10

Closed ydnar closed 9 months ago

ydnar commented 9 months ago

Fixes #8.

rajatjindal commented 9 months ago

thank you so much for the PR (and all the work you do for open source community).

if you have a few mins, could you please add a testcase in https://github.com/bytecodealliance/actions/blob/main/.github/workflows/wasmtools-tests.yml for the new wasm-tools format. (or I am happy to add it myself in a follow up PR).

I’m happy to update this to have wasmtime accept a bare version without the v prefix.

what do you think would be better: to accept version without v prefix or update actions to support both formats (with/without prefix) to avoid any confusions.

thanks

ydnar commented 9 months ago

Thanks for making this! I have a few projects that use it—it’s been handy to have an official setup action for wasmtime, wasm-tools, and wit-bindgen.

ydnar commented 9 months ago

OK, tests pass. I rebased and squashed.

ydnar commented 9 months ago

Would it make sense to bump the release to v1.1 after this is merged?

I can update the README to reflect that and the changes to the accepted version spec.

rajatjindal commented 9 months ago

Hi @ydnar , thank you for making the changes and adding the tests.

given these changes are backward compatible (please correct me I misread this), I think we can just make a patch release.

In anycase, for v1.x.y, we will move tag v1 to point to latest release automatically (this is the norm I have seen in other actions), so it should be fine either way.

Thanks

rajatjindal commented 9 months ago

Please let me know if you have opinion about patch vs minor release, and I will cut the new release accordingly. thanks again.

ydnar commented 9 months ago

It's backwards compatible as far as I can tell from the tests. Any version is probably fine.

Do you want to update the README?

rajatjindal commented 9 months ago

yeah, that would be great. thank you.

ydnar commented 9 months ago

Done!