Open ChenKS12138 opened 2 years ago
Oops, some checks are stills be not successful, IMHO maybe examples/markdown
is not a suitable example for cargo-wasi, we need to remove it, as @alexcrichton says
the wasm32-wasi target is not compatible with wasm-bindgen
https://github.com/rustwasm/wasm-bindgen/issues/2554#issuecomment-840774170
Or, we should allow users to pass and override the target
argument, something like that. (It works well to compile examples/markdown
if I have changed the target)
cargo wasi build -p markdown --release --verbose --target wasm32-unknown-unknown
- As @PiotrSikora says, in order to run
wasm_opt
, a dynamic library needs to be installed (for Linux and mac os). Update wasm-opt to version_97. #91 (comment) And the cache folder's structure will be as follow.
- bump
wasm_opt
version fromversion_97
toversion_105
wasm32-unknown-unknown
when compiling example/markdown
on CI.Sorry there's a good number of changes here and I don't have a ton of time to review this right now. If wasm-opt-the-builtin-version isn't working well I'd recommend disabling it and then manually running it afterwards.
I have removed the code that updating wasm-opt
version, and I believe this is the minimum code changes to let CI checks pass.
There is no problem with wasm-opt-the-builtin-version, but an essential library (libbinaryen.dylib/libbinaryen.a) is not installed and linked.
wasm_opt
, a dynamic library needs to be installed (for Linux and mac os). https://github.com/bytecodealliance/cargo-wasi/pull/91#issuecomment-787433832 And the cache folder's structure will be as follow.wasm_opt
version fromversion_97
toversion_105