bytecodealliance / cranelift

Cranelift code generator
https://cranelift.readthedocs.io/
2.49k stars 202 forks source link

Add initial support for EVEX encodings #1370

Closed abrown closed 4 years ago

abrown commented 4 years ago
abrown commented 4 years ago

@iximeow, thanks for all of the help! (And @peterhuene too!) I believe this is ready for an actual review--@iximeow, can you take a look? I rebased the commits into some semblance of order so they should be reviewable from oldest to newest (fun fact of the day: I had to redate them for GitHub to show them in order). Since we likely won't want to squash these things, I made sure the commits are bisectable by running git rebase master --exec 'cargo test --all' with no issues.

I would like to be able to actually run this new instruction on AVX512 hardware with a test run filetest but I will try that in a future PR; currently I don't think we have the ability to skip test run filetests when the target doesn't match the host's CPU features (or do we?).

bnjbvr commented 4 years ago

Closing in favor of https://github.com/bytecodealliance/wasmtime/pull/1192.