bytecodealliance / javy

JS to WebAssembly toolchain
Apache License 2.0
2.06k stars 100 forks source link

[Submodule] Use https over git protocol #683

Closed ewalk153 closed 1 week ago

ewalk153 commented 1 week ago

Description of the change

https is the preferred protocol for cloning repos. This switches the test262 reference to the https protocol.

Why am I making this change?

Cloning the submodule for test262 was failing for me.

Test instructions:

git submodule sync
git submodule update

Previously, I was hitting this security error:

➜  javy git:(add-crypto-hmac-256) ✗ git submodule update
Cloning into '/Users/a_user_name/src/github.com/bytecodealliance/javy/crates/javy/test262'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:tc39/test262.git' into submodule path '/Users/a_user_name/src/github.com/bytecodealliance/javy/crates/javy/test262' failed
Failed to clone 'crates/javy/test262'. Retry scheduled
Cloning into '/Users/a_user_name/src/github.com/bytecodealliance/javy/crates/javy/test262'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:tc39/test262.git' into submodule path '/Users/a_user_name/src/github.com/bytecodealliance/javy/crates/javy/test262' failed
Failed to clone 'crates/javy/test262' a second time, aborting

Checklist