Tidy up event loop handling code - Githubissues

bytecodealliance / javy

JS to WebAssembly toolchain

Apache License 2.0

2.16k stars 103 forks source link

Tidy up event loop handling code #697

Closed saulecabrera closed 2 months ago

saulecabrera commented 2 months ago

This commit refactors the event loop handling code, mainly by extracting the common pieces into a reusable function.

Additionally, this commit ensures that the result of Promise.finish is corectly handled, which fixes execution of code with top level awaits.

Finally, this commit also ensures that we test the experimental_event_loop in CI for the CLI and core crates (follow-up to https://github.com/bytecodealliance/javy/pull/238)

Checklist

[x] I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-core do not require updating CHANGELOG files.
[x] I've updated the relevant crate versions if necessary. Versioning policy for library crates
[x] I've updated documentation including crate documentation if necessary.

saulecabrera commented 2 months ago

There's something strange about this failure, it's not failing locally. Let me look into it. I'll report back once it's solved.