Closed jeffcharles closed 20 hours ago
The check takes 25 minutes to run. Part of the reason for that is it has to rebuild everything without a cache.
And yeah, it looks like this just tests the experimental event loop. And yeah, we could use a -J
flag instead.
Closing since we got rid of the GitHub Actions workflow this PR was changing
Description of the change
Uses the same feature configuration for building the default Javy plugin and Javy CLI when building the test plugin.
The really fast way to do this might be to have some way to skip the test plugin integration tests for this workflow.
Another thought that comes to mind is we might be busting the cargo target cache unintentionally since we're always emitting a build with the feature flag enabled as the last build step that runs. We could configure the
ci-shared-setup
to use a slightly different cache key for the Cargo target cache for this workflow.Why am I making this change?
This workflow runs quite a bit slower because we have to compile the plugin and the CLI twice because they have different features enabled. Using the same features means it should be able to re-use the build artifacts across steps.
Checklist
javy-cli
andjavy-plugin
do not require updating CHANGELOG files.