bytecodealliance / jco

JavaScript toolchain for working with WebAssembly Components
https://bytecodealliance.github.io/jco/
Apache License 2.0
618 stars 62 forks source link

Fix definedResourceTables ReferenceError with instantiation mode #456

Closed kateinoigakukun closed 3 months ago

kateinoigakukun commented 3 months ago

The js_instrinsics should be defined under the instantiate function. Otherwise we get the following error:

dist/component/ruby.component.js:73
  if (definedResourceTables[toTid]) return rep;
  ^

ReferenceError: definedResourceTables is not defined

https://github.com/ruby/ruby.wasm/actions/runs/9708747430/job/26796119275?pr=479#step:14:302