bytecodealliance / lucet

Lucet, the Sandboxing WebAssembly Compiler.
Apache License 2.0
4.06k stars 165 forks source link

[PR into tyler/uffd-integration] Fixes uncovered during review of #492 #494

Closed acfoltzer closed 4 years ago

acfoltzer commented 4 years ago

This first commit enables alloc tests for UffdRegion, adds a new test, and fixes some things:

acfoltzer commented 4 years ago

This PR now also enables the uffd feature by default, but filters on OS.

Notably, this should get us building and running uffd in Linux CI.

It turns out to be a tremendous pain to enable a feature flag for just one crate within a workspace. The situation is being addressed, but in the meantime I believe the best route forward is to just have uffd on by default for Linux.

acfoltzer commented 4 years ago

Okay, the CI issue is still outstanding, but I'm happy with merging this into your branch, @tyler