Allow use of pinned heap registers

bytecodealliance / lucet

Lucet, the Sandboxing WebAssembly Compiler.

Apache License 2.0

4.06k stars 165 forks source link

Allow use of pinned heap registers #512

Open shravanrn opened 4 years ago

shravanrn commented 4 years ago

@pchickey @awortman-fastly @iximeow Slightly cleaned up and rebased version of https://github.com/bytecodealliance/lucet/pull/273 with some comment fixes

I've left the code mostly as is although some of the changes here seem orthogonal. Wanted to ask about this first before removing the code

Context save for sandbox is also saving the value for register r8
In stack.rs, there is a stack overflow test where the size of the stack seems to be bumped.

Let me know if I should remove either of these, and I can update the PR

shravanrn commented 4 years ago

Sorry, just wrapping some other work. Will update the pr shortly

shravanrn commented 4 years ago

Made the changes. Hopefully the r15 bit is not too hacky --- i was trying to avoid pulling in new dependencies. Also, restored the stack size in the test. Haven't tested this though. Waiting for CI to complete, and will fix things

shravanrn commented 4 years ago

@iximeow looks like the tests pass with the old stack size. I think this is ready for review?

shravanrn commented 4 years ago

ping :slightly_smiling_face:

pchickey commented 4 years ago

This PR was closed as a byproduct of deleting the branch named master. If this is still an active PR, re-open as a new PR against main.

iximeow commented 4 years ago

Just a heads up, I pushed a small commit here that specifically lists what heap pinning approach lucetc builds a module expecting. With that (or a change like it) I'd be happy to :heavy_check_mark: but I can't push to this branch so either you can cherry pick it or I can rebase these two and put up a new PR. Either works!

We've enabled CircleCI for some of our CI workflow since this branch got put up, so either way it'll need to pick up that configuration to get a pass on CI now.