search

bytecodealliance / lucet

Lucet, the Sandboxing WebAssembly Compiler.
Apache License 2.0
4.06k stars 164 forks source link

Update the object crate to the same version as wasmtime #621

Closed jedisct1 closed 3 years ago

jedisct1 commented 3 years ago

Having different versions of the same dependency is not a good idea, and lucet-module couldn't see the lucet_module_data symbol any more on macOS.

This repairs signatures on macOS.

pchickey commented 3 years ago

I wonder if we should get cranelift-object to re-export object (e.g. pub use object::*) so that we can track just one dep here.

jedisct1 commented 3 years ago

Sure! Re-exporting dependencies would indeed help a lot with such cases.

pchickey commented 3 years ago

turns out it already does, ill follow up with a PR that swaps to it

pchickey commented 3 years ago

turns out that the cranelift-object re-export does not include the read cargo feature, which are what we are actually using here. Rather than make upstream expose just the right feature to our liking (read_core and elf, to avoid the dupe wasmparser dep), we should instead just keep the dep.