Don't use non-constant string as panic!()'s first argument

bytecodealliance / lucet

Lucet, the Sandboxing WebAssembly Compiler.

Apache License 2.0

4.06k stars 165 forks source link

Closed jedisct1 closed 3 years ago

jedisct1 commented 3 years ago

This is no longer accepted in Rust 2021.

Also remove a column sign after a function definition (how come that did even compile?)

acfoltzer commented 3 years ago

These aren't strings, they're values that we use with Any in order to control the unwinding of guest termination and should keep them as-is.

We should get rid of that semicolon, though :slightly_smiling_face:

jedisct1 commented 3 years ago

Thanks!

I guess we have to wait for the next release and use panic_any, then.

acfoltzer commented 3 years ago

Ah yes, looks like it! I didn't know about that API change. Thanks for keeping eyes out for us

jedisct1 commented 3 years ago