bytecodealliance / lucet

Lucet, the Sandboxing WebAssembly Compiler.
Apache License 2.0
4.06k stars 165 forks source link

Make the new Cranelift x64 backend the default. #646

Closed cfallin closed 3 years ago

cfallin commented 3 years ago

After sufficient testing, we're confident that the new x64 backend does not have any correctness issues relative to the old backend; and because it generates better code, we would like to switch the default. This PR will cause lucetc to use the new backend by default. Building lucetc with the old-x64-backend Cargo feature will swap the old backend in again. This PR also removes the separate new-backend CI tests.

pchickey commented 3 years ago

Can we keep the old backend testing in CI for a little while longer? Instead of deleting the new-backend CI jobs we can change them to be old-backend.

cfallin commented 3 years ago

Can we keep the old backend testing in CI for a little while longer? Instead of deleting the new-backend CI jobs we can change them to be old-backend.

Yes, for sure, that makes sense! Updated.